klaviyo / klaviyo-swift-sdk

SDK that allows users to incorporate Klaviyo's event and person tracking functionality within iOS applications. Written in Swift.
MIT License
10 stars 10 forks source link

Fix broken invalid url handling on iOS 17 #136

Closed ajaysubra closed 5 months ago

ajaysubra commented 5 months ago

Description

In iOS 17 apple changes how url's string initializer works and this was causing one of our tests that validates invalid urls to fail. I reverted the URL initializer to not use the new decoding and sticking with the pre iOS 17 logic of keeping invalid characters from decoding. This is fine since the string we are using the URL initializer is a static one and the idea is to align the code with the tests we had.

Change in iOS 17 for more context.

Check List

Manual Test Plan

1.

Supporting Materials

evan-masseau commented 5 months ago

@ajaysubra assume you won't mind, i updated this against master so we can see if CI 100% is fixed now.

evan-masseau commented 5 months ago

hm CI is hung on 14.3 tests, which I think you removed. Might have to force-merge this one, maybe those tests are cached or something?

ajaysubra commented 5 months ago

hm CI is hung on 14.3 tests, which I think you removed. Might have to force-merge this one, maybe those tests are cached or something?

Thanks for updating with master. You are probably right that GH is caching something. Manually triggered the jobs 🤞🏽

ajaysubra commented 5 months ago

Actions is passing but it's not updating the PR so I'm going to just merge this bypassing the checks. image