search

klaviyo / magento2-klaviyo

37 stars 51 forks source link

adding code changes to handle infinite loop issue #136

Closed klaviyojad closed 2 years ago

klaviyojad commented 2 years ago

This pertains to github issue here and implements some of the logic here as its still unreleased code.

It addresses the bug where if a quote with a coupon has trigger_recollect = 1 then any api calls to retrieve the quote will hang forever. Instead of relying on the magento libraries to retrieve the masked quote id, we implement code to retrieve it ourselves from the DB

jordanallain commented 2 years ago

Looks good, were you able to test it?

klaviyojad commented 2 years ago

@jordanallain was tested by api call [store url]/rest/V1/carts/[quote id] that hangs for quote with coupon and trigger_recollect = 1 before change and doesnt after this change is made