search

klaviyo / magento2-klaviyo

37 stars 51 forks source link

Update cart.phtml #154

Closed JamesFX2 closed 2 years ago

JamesFX2 commented 2 years ago

Fixes for us, somehow being called before this is set in other places.

siddwarkhedkar commented 2 years ago

Hey @JamesFX2 , What is the issue you are facing and how does this fix work? Could you please provide a summary of why this is necessary?

It will be great if you could also mention what version of the extension you are using, what version of M2 you are on

JamesFX2 commented 2 years ago

Latest version of your extension. V2.3.5

Not sure if this is being caused by MagePack or your extension but it's calling /checkout/cart/reclaim/checkout/reload (404) on our release site's cart page. I guess it's being called before the baseUrl is set.

I've added an override in our theme that does this so your call if you take it or not.

siddwarkhedkar commented 2 years ago

Hey @JamesFX2 , I'm going to close out this PR and add this to our backlog to take a look into this soon. After testing, we'll decide if we want to make the change to any future extensions