search

klaviyo / magento2-klaviyo

37 stars 51 forks source link

Private API Key Stored in plain text #18

Closed pmclain closed 4 years ago

pmclain commented 5 years ago

https://github.com/klaviyo/magento2-klaviyo/blob/master/etc/adminhtml/system.xml#L21-L23 Should this be an obscure config value instead of text?

Pr00xxy commented 5 years ago

Also consider using the Encrypted backend model <backend_model>Magento\Config\Model\Config\Backend\Encrypted</backend_model> together with Magento\Framework\Encryption\EncryptorInterface::decrypt() when accessing value

njparadis commented 4 years ago

Hey guys, this is being addressed in PR #54: https://github.com/klaviyo/magento2-klaviyo/pull/54/files#diff-c4a53edec4557757b0db215231c89c32R21