search

klaviyo / magento2-klaviyo

37 stars 51 forks source link

Fix 404 AJAX Request #195

Closed jlenzstaysafe closed 1 year ago

jlenzstaysafe commented 2 years ago

The base URL needs to be set, otherwise you will generate a relative URL which will 404 on any URL that has a path with more than 1 level deep (ie: /checkout/cart)

cykolln commented 2 years ago

This looks good to me and has been tested on our end. Can you please update the CHANGELOG.md and add this fix into the Unreleased section, once this is in we can get it approved and merged. We typically do releases on a monthly cadence so this will be included in July's release.

jlenzstaysafe commented 2 years ago

Just to clarify, is this the format/text you're looking for? ie:

[Unreleased]

cykolln commented 2 years ago

Just to clarify, is this the format/text you're looking for? ie:

[Unreleased]

  • Fix 404 AJAX Request

Yes, thats great - this just helps us track what is unreleased in master so we can draft the next release.

cykolln commented 1 year ago

Merged - this should be released in the next two weeks bundled with some other bug fixes. Thanks for your contribution!