klaviyo / magento2-klaviyo

37 stars 51 forks source link

Make SMS Editable for Logged Customers at the Checkout Page #205

Closed pauloharaujos closed 1 year ago

pauloharaujos commented 1 year ago

This PR makes the SMS Phone Number Field Editable for Logged Customers. Also, this saves the phone number inside the customer's address and quote address. This makes more easily for the customer to update the phone number before checking the option to send the phone number to Klaviyo. Without those changes, the customer needs to go to My Account and edit the address before going to the checkout page.

smoucka commented 1 year ago

Hi @pauloharaujos , thanks for this submission. Upon initially testing, this isn't working for me. I'm going to return to this first thing next week and will review further. Thanks again!

pauloharaujos commented 1 year ago

Hi @smoucka ,

Thanks for your tests. I'll check this again this week as well.

pauloharaujos commented 1 year ago

Hi @smoucka ,

I fixed the issues and looks good for me now. Could you please review it again when you have a chance? Thanks.

smoucka commented 1 year ago

Hi @pauloharaujos

Thank you for making those updates. I spoke with our Product Manager about your contribution and while we like the direction this is going in we'd prefer not to update the shipping address and instead to allow the SMS consent phone number to remain separate from the quote/customer address. Along with this functionality change we're going to reconfigure the layout of the consent at checkout feature.

As a result, we've created a feature request for these updates and will include your contribution in a future PR.

pauloharaujos commented 1 year ago

Hi @smoucka ,

Thanks for reviewing it and for the update. I appreciate.

smoucka commented 1 year ago

Hi @pauloharaujos , thank you again for your contribution. I'm going to close this PR and we'll incorporate these changes in a future enhancement to our extension.