TP156258: Switch from _learnq to klaviyo object in javascript

klaviyo / magento2-klaviyo

37 stars 51 forks source link

Closed award28 closed 1 year ago

award28 commented 1 year ago

Updated the legacy _learnq js object to the new klaviyo js object.

Validated the klaviyo object is available when the klaviyo.js script is installed.

[x] You've updated the CHANGELOG following the steps here
[ ] Internal Only - If this is a release, have you:
- [ ] Updated the links in the CHANGELOG to point towards the new versions
- [ ] Incremented the version in the following places: module.xml and composer.json

klaviyobot commented 1 year ago

award28 commented 1 year ago

I'm not going to create a release just for this change - it can go out with the next scheduled release.

toddbc commented 1 year ago

klaviyo.isIdentified() returns a promise so I think this introduces some issues. _learnq.isIdentified() did not return a promise.

cykolln commented 1 year ago

klaviyo.isIdentified() returns a promise so I think this introduces some issues. _learnq.isIdentified() did not return a promise.

@toddbc thank you for raising this - we are rolling this change back with a plan to fix and include it in a future release