TP157760: Validate the email is not the empty string

award28 commented 1 year ago

Description

Makes sure the set $email in $kl_decoded_cookie is not the empty string.

Manual Testing Steps

> $kl_decoded_cookie = ["email" => ""]
= [
    "email" => "",
  ]

> isset($kl_decoded_cookie["email"])
= true

> isset($kl_decoded_cookie["email"]) && !empty($kl_decoded_cookie["email"])
= false

Pre-Submission Checklist:

[ ] You've updated the CHANGELOG following the steps here
[ ] Internal Only - If this is a release, please confirm the following:
- [ ] The links in the changelog have been updated to point towards the new versions
- [ ] The version has been incremented in the following places: module.xml and composer.json

NOTE: Please use the Changelogger cli tool to manage versioned file upgrades.

klaviyobot commented 1 year ago

https://klaviyo.tpondemand.com/entity/157760

chavesj commented 1 year ago

Looking at https://phppot.com/php/isset-vs-empty-vs-is_null/ it seems that empty will cover the cases of null, undefined, and "" so AFAICT the check for isset is no longer needed

award28 commented 1 year ago

@chavesj Good catch! I'll remove it from the PR before merging.

klaviyo / magento2-klaviyo