klaviyo / magento2-klaviyo

37 stars 51 forks source link

update response handling for false #282

Closed cykolln closed 6 months ago

cykolln commented 6 months ago

Description

This PR fixes behavior for when curl_exec returns something that is not explicitly false but evaluates to false (ex: null). This will prevent successful responses from retrying and follows the recommendation here: https://www.php.net/manual/en/function.curl-exec.php#refsect1-function.curl-exec-returnvalues

Manual Testing Steps

1.

Pre-Submission Checklist:

NOTE: Please use the Changelogger cli tool to manage versioned file upgrades.