klaviyo / magento2-klaviyo

37 stars 51 forks source link

Adds urlencode to email before search request #299

Closed cykolln closed 1 month ago

cykolln commented 1 month ago

Description

Fixes a bug where we weren't url encoding emails before requesting the api/profiles/ endpoint. For emails containing special characters this was resulting in misses on the search and the following request to create the new profile would fail because it does already exist.

Manual Testing Steps

  1. Selected to not use Klaviyo's opt-in settings in the extension settings. Then filled out the M2 footer form with an email that already existed in Klaviyo, made sure it was properly added to list.
  2. Tested the same as above but with a new email that didn't exist in Klaviyo.

Pre-Submission Checklist:

NOTE: Please use the Changelogger cli tool to manage versioned file upgrades.

cykolln commented 1 month ago

Fixes https://github.com/klaviyo/magento2-klaviyo/issues/295