search

klaviyo / magento2-klaviyo

37 stars 51 forks source link

Malformed JSON when product name contains a quote character #30

Closed sippsolutions closed 5 years ago

sippsolutions commented 5 years ago

Fixes #15

remstone7 commented 5 years ago

looks good! just one comment

srenon commented 5 years ago

@remstone7 @invertedfjord ... this issue will be fixed by https://github.com/klaviyo/magento2-klaviyo/pull/14 ...

You should close this PR and not merged into Master otherwise you going to run in a merge conflict.

All this logic was more to https://github.com/klaviyo/magento2-klaviyo/pull/14/files#diff-18bedff8355a70ed70280a6e72eadd4dR190 and then JSON encode.