search

klaviyo / magento2-klaviyo

38 stars 51 forks source link

Fix reporting Unsubscribe from List event #57

Closed ihor-sviziev closed 4 years ago

ihor-sviziev commented 4 years ago

Switch to Klaviyo Lists v2 API endpoint This endpoint triggers "Unsubscribed from %ListName%" event

ihor-sviziev commented 4 years ago

@remstone7 I added fix. I wanted to migrate to some magento class that doing what you need - but it doesn't support DELETE requsts O_o https://github.com/magento/magento2/pull/25742

ihor-sviziev commented 4 years ago

In general I would like to extract all logic that sends requests to API to some model(s), but it definitely would be separate PR. Now my need - fix the issue

remstone7 commented 4 years ago

just 1 conflict should be a quick fix -- also, we're just bringing this down to test today/tomorrow and will merge with out 1.1.7 release

ihor-sviziev commented 4 years ago

@remstone7 I fixed conflict

ihor-sviziev commented 4 years ago

@remstone7 I see that you already released version 1.1.7 and 1.1.8, did you missed to merge this PR?

remstone7 commented 4 years ago

Missed this but merging now, had an urgent fix we had to get out. Itll go out in 1.1.9 which should be in the next couple weeks