klaviyo / magento2-klaviyo

37 stars 51 forks source link

No ACL rules #98

Closed vseager closed 3 years ago

vseager commented 3 years ago

There are no ACL rules so that config access cannot be granted to individual user roles:

https://devdocs.magento.com/guides/v2.4/ext-best-practices/tutorials/create-access-control-list-rule.html

klaviyojad commented 3 years ago

Hi @vseager below are ACLs you can configure that would satisfy all the api requirements from Klaviyo:

"Catalog > Inventory > Categories", "Carts > Manage Carts", "Customers > Customer Groups", "Customers > All Customers", "Sales > Operations > Orders > Actions > View" "Stores > Attributes > Product", "Catalog > Inventory > Products" "Sales > Operations > Shipments" "Stores > Settings > All Stores" "Marketing > Communications > Newsletter Subscribers"

vseager commented 3 years ago

@klaviyojad I wasn't referring to the API requirements but the settings in Stores > Settings > Configuration. At the moment there is no way to control access to Klaviyo configuration for different user roles (System > Permissions > User Roles).

klaviyo

klaviyo2

klaviyojad commented 3 years ago

@vseager you are correct that we currently do not define any new ACLs for access to the Klaviyo extension config as well as new klaviyo endpoints. Its something we'll have to add to the roadmap

vseager commented 3 years ago

@klaviyojad do you have an update on this issue?

klaviyojad commented 3 years ago

@vseager again its on the roadmap. Nothing we are working on currently. Is it blocking you from anything?

cykolln commented 3 years ago

This feature request has been added to the roadmap - closing because it is not an issue

vseager commented 3 years ago

@cykolln Was this fixed? There is still no /etc/acl.xml in the repo?

cykolln commented 3 years ago

@cykolln Was this fixed? There is still no /etc/acl.xml in the repo?

We created a feature request for this issue and added it to our roadmap. When it gets picked up, a member of the team will follow up.

vseager commented 2 years ago

@cykolln Any change of getting this fixed? It really is a 5 minute change?!

mortenbirkelund commented 2 years ago

Still nothing?

kasperth commented 1 year ago

@cykolln @klaviyojad when do you reckon this will be looked into? as vseager wrote, it's a small change.