search

klaviyo / php-klaviyo

PHP wrapper for the Klaviyo API
59 stars 48 forks source link

Feature/post public api #66

Closed kamil-klasicki closed 3 years ago

kamil-klasicki commented 3 years ago

Change public api to use Post JSON instead of a GET request. (Most of the changes are simply due to running a linter)

mangoceylon commented 3 years ago

We aren't going to be deprecating GET, and we desire keeping the current functionality while allowing POST as an option.

kamil-klasicki commented 3 years ago

Is there a reason to keep GET request if the functionality for the users does not change at all? It seems to defeat the purpose of an SDK if we give customers the option to pick between GET and a POST. The more abstracted the SDK the better (Unless we have a reason not to use POST). This change will have zero impact on existing users of the sdk