search

klay-music / klay-beam

Our Apache Beam Transforms and Pipelines
1 stars 0 forks source link

Unify the docker tagging scripts #35

Closed mxkrn closed 1 year ago

mxkrn commented 1 year ago

Right now we're duplicating the tag-klay-beam-<job_name>.sh script in order to link a specific tag to a specific job. Let's think of a better way to do document / save a docker image version whilst only using a single tag-klay-beam.sh script.

Usually I would suggest this to be a git tag related to a python package. Since we have multiple python packages I would suggest to make a text file: VERSION, in which we include a string formatted as:

<major>.<minor>.<rev>-<job_name>

Where the major, minor, and rev values are based on the current value in klay_beam/src/klay_beam/__init__.py.

CharlesHolbrow commented 1 year ago

Docker tagging is going to be handled with Makefile. See #45 .