search

klaytn / caver-js

Official caver-js repository
GNU Lesser General Public License v3.0
114 stars 75 forks source link

caver-js/types/packages/caver-utils/src/index.d.ts hexToNumber type mismatch #634

Closed kkeolmusae closed 2 years ago

kkeolmusae commented 2 years ago 
hexToNumber(value: string | number | BN): string

I think this should be fixed to hexToNumber(value: string | number | BN): string -> hexToNumber(value: string | number | BN): number.

ref) https://docs.klaytn.com/dapp/sdk/caver-js/api-references/caver.utils#hextonumber

jimni1222 commented 2 years ago

I fixed https://github.com/klaytn/caver-js/pull/635

kjhman21 commented 2 years ago

@Seunghwan96 Thanks for sharing the issues. Of course, since klaytn and caver-js is an open-source repository, you can also contribute. :)