QA for v1.10.2 - Githubissues

aidan-kwon commented 1 year ago

Misc

1745
1757
1768

Regular tests

[ ] https://github.com/klaytn/klaytn/issues/1802#issuecomment-1455339354 - @JayChoi1736

Other updates

caver-js update
caver-java update
klaytn-docs update

ian0371 commented 1 year ago

Governance parameters vote test
- homi setup local --baobab-test --cn-num 4 --funding-addr 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266 --patch-address-book --patch-address-book-addr 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266 [--kore-compatible-blocknumber 9999999]
- Test in the following order:
- Check without additional preparation: istanbul.committeesize, governance.unitprice, governance.deriveshaimpl
- Activate the AddressBook and stake [7m 6m 5m 4m] and continuously send transactions: reward.*
- Use klaytn-burst-fee-test: kip71.*
- Deploy GovParam.sol: governance.govparamcontract
- In the table below, "A" refers to the governance activation block (i.e. [nearest epoch block since vote] + [1 epoch])

Parameter name	before	after	how to check (in addition to klay.getParams())	pre-Kore activation	post-Kore activation
istanbul.committeesize	13	2	klay.getCommittee(), klay.getBlock().extraData	A+1	A+0
governance.unitprice	25 ston	10 ston	klay.gasPriceAt()	A+1 (no effect)	A+0 (no effect)
governance.deriveshaimpl	2	0	klay.getBlock().transactionsRoot	A+1	A+0
reward.mintingamount	9.6 KLAY	6.4 KLAY	klay.getRewards(), klay.getBalance()	A+1	A+0
reward.ratio	34/54/12	50/40/10	klay.getRewards(), klay.getBalance()	A+1	A+0
reward.kip82ratio	20/80	100/0	klay.getRewards(), klay.getBalance()	A+1 (no effect)	A+0
reward.useginicoeff	false	true	klay.getStakingInfo().useGini	A+1 (effective from next staking interval)	A+0 (effective from next staking interval)
reward.deferredtxfee	true	false	klay.getRewards(), klay.getBalance()	A+1	A+0
reward.minimumstake	5m	6m	klay.getCommittee()	A+1	A+0
kip71.lowerboundbasefee	25 ston	40 ston	klay.getBlock().baseFeePerBlock	A+1	A+0
kip71.upperboundbasefee	750 ston	600 ston	Using burst-fee-test, keep pushing up basefee	A+1	A+0
kip71.gastarget	30m	22m	Using burst-fee-test, measure basefee delta	A+1	A+0
kip71.basefeedenominator	20	10	Using burst-fee-test, measure basefee delta	A+1	A+0
kip71.maxblockgasusedforbasefee	60m	77m	Using burst-fee-test, measure basefee delta	A+1	A+0
governance.govparamcontract	0x0	deployed address	Populate GovParam with setParamIn(deriveshaimpl,true,2,1) and then vote govparamcontract address	A+1 (no effect)	A+0

not tested
- governance.governancemode
- governance.governingnode
- istanbul.epoch
- istanbul.policy
- reward.stakingupdateinterval
- reward.proposerupdateinterval
- governance.addvalidator
- governance.removevalidator
- param.txgashumanreadable
- istanbul.timeout

klaytn-issue1802-v1.10.2-governance-qa.md

JayChoi1736 commented 1 year ago

Regular QA Test

[x] Rolling Update test:
- rolling.log
[x] RPC/WS test:
- KlaytnTestReport_2023-03-13_15-40-54.html.zip
[x] Governance test:
- governance.log
[x] Reward test:
[ ] Caver js/java test:
[x] Sync test:
- sync node setting: r6i.2xlarge, gp3, 16000 iops, 1000 throughput

network	sync duration	sync time	Latest DB size
baobab	0 to 116278122	3d 7h 35m	389G
cypress	0 to 52007590	5d 21h 53m	1.5T
cypress	52007591 to 76539733	8d 4h 25m	3.1T
cypress	76539734 to 85287012	8d 0h 2m	5.1T
cypress	85394216 to 116650000	11d 11h 7m	6.9T

Unusual logs during sync test none

Warning logs about network connection during sync test

RetrieveNodes: Not Supported NodeType     Discover=Table  NodeType=1 // findNode for CN nodetype(1) is not allowed
Bad discv4 packet                         addr=3.36.78.12:32333     err="too small" // udp packet with too short size is discarded

grafana result: Klaytn Main Overview - Grafana.pdf
[x] Load test
- [x] Stress: 10000 RPS load test for 30m
- TC: transferSignedTx
- TPS: 5610
- CN : m6i.8xlarge
- block mining time : 0.998s
- grafana image
  ![stress](https://user-images.githubusercontent.com/102955810/225175415-28582501-4af4-46dd-bfee-05b6aa085ad9.png)
- [x] Reliability: 2000 RPS load test for 72h
- TC: transferSignedTx, newValueTransferTC, newFeeDelegatedSmartContractExecutionTC
- TPS: 2000
- Peer Connection: stable
- BlockGenerationTime: 0.992s
- grafana image
  ![reliable](https://user-images.githubusercontent.com/102955810/225487412-111badab-d8fa-4f33-97f2-6929edad194f.png)
[x] API performance test:
- TC : readBlockNumber, readGetAccount, readGetBlockByNumber, readGetBlockWithConsensusInfoByNumber
- EN : m6i.4xlarge * 1
- result
- Version 1.10.0 1.10.2-rc.3
  
  readBlockNumber 164906 173340
  
  readGetAccount 94581 99345
  
  readGetBlockByNumber 216.90 167.76
  
  readGetBlockWithConsensusInfoByNumber 245.23 194.71

Version	1.10.0	1.10.2-rc.3
readBlockNumber	164906	173340
readGetAccount	94581	99345
readGetBlockByNumber	216.90	167.76
readGetBlockWithConsensusInfoByNumber	245.23	194.71

blukat29 commented 1 year ago

Consensus committed seal count test

Inspect klay.getBlock(num).extraData to see how many seals (signatures) are in the block.

Modify councilSize by governance.vote(governance.removevalidator)
Modify committeeSize by governance.vote(istanbul.committeesize)
Use rlp decode 0xf9... | jq to decode extraData (use rlp package)
Below table shows number of CommittedSeals in a block extraData.

# of CommittedSeals ↓ committeeSize \ councilSize →	1	2	3	4
1	1	1	1	1
2	1	2	2	2
3	1	2	3	3
4	1	2	3	3

In contrast, in v1.10.1, if councilSize=4 and committeeSize=2 a block contains 1 CommittedSeals.

klaytn-issue1802-v1.10.2-pr1787-qa.md

blukat29 commented 1 year ago

Debug trace timeout test

Create large Tx using klaytn-burst-fee-test
Prevent accidental DoS
- [x] Call debug.traceTransaction(txid) - returns less than a second and throws "trace logger timeout"
Allow custom timeout
- [x] Call debug.traceTransaction(txid, {loggerTimeout:"3s"}) - runs for the specified amount of time. No memory increase after timer ends.

yoomee1313 commented 1 year ago

transaction size test (tested with valueTransferForMemo txType) Tx size	accepted	data	gas	error
16KB	yes	'0x' + '11'.repeat(16241)	1645100	-
32KB	yes	'0x' + '11'.repeat(32625)	3283500	-
127KB	yes	'0x' + '11'.repeat(129903)	13011300	-
128KB	yes	'0x' + '11'.repeat(130927)	13113700	-
129KB	failed	'0x' + '11'.repeat(131951)	-	`Error: Returned error: oversized data`
162KB	failed	'0x' + '11'.repeat(165743)	-	`Error: Returned error: oversized data`

ian0371 commented 1 year ago

"Missing trie node" bug fix test

How to reproduce the bug

Spawn 1CN-1PN
deploy GovParam & call governance.vote("governance.govparamcontract", <nonzero-addr>)
wait to sync more than 128 blocks
stop PN (docker-compose stop PN-0)
respawn PN (docker-compose start PN-0)

If the log contains the following messages, the bug is successfully reproduced.

INFO[03/07,02:38:00 Z] [5|blockchain/blockchain.go:499]              Loaded most recent local header           number=140 hash=5160b9…a2fe77 td=141 age=7s
INFO[03/07,02:38:00 Z] [5|blockchain/blockchain.go:500]              Loaded most recent local full block       number=140 hash=5160b9…a2fe77 td=141 age=7s1ms
INFO[03/07,02:38:00 Z] [5|blockchain/blockchain.go:501]              Loaded most recent local fast block       number=140 hash=5160b9…a2fe77 td=141 age=7s1ms
WARN[03/07,02:38:00 Z] [5|blockchain/blockchain.go:310]              Head state missing, repairing chain       number=140 hash=0x5160b9b6b2e2c258d04063c705d9c03d1875f6d34a1f2b1f557ee0b24ca2fe77
INFO[03/07,02:38:00 Z] [5|blockchain/blockchain.go:499]              Loaded most recent local header           number=140 hash=5160b9…a2fe77                                                      td=141 age=7s7ms
INFO[03/07,02:38:00 Z] [5|blockchain/blockchain.go:500]              Loaded most recent local full block       number=128 hash=e8abee…f5fe10                                                      td=129 age=7s7ms
INFO[03/07,02:38:00 Z] [5|blockchain/blockchain.go:501]              Loaded most recent local fast block       number=140 hash=5160b9…a2fe77                                                      td=141 age=7s7ms
ERROR[03/07,06:17:08 Z] [30|governance/contract_connector.go:119]      Could not find the state                  err="missing trie node d3cbe0a3f27885353d33a7db622a82123302f15baf41f11ca5bad855a58dade6 (path )" num=146
ERROR[03/07,06:17:08 Z] [30|governance/mixed.go:158]                   contractGov.UpdateParams() failed         err="missing trie node d3cbe0a3f27885353d33a7db622a82123302f15baf41f11ca5bad855a58dade6 (path )"
Fatal: Error starting protocol stack: missing trie node d3cbe0a3f27885353d33a7db622a82123302f15baf41f11ca5bad855a58dade6 (path )

After the fix, the ERROR logs (Could not find the state, UpdateParams failed) must not appear.

ian0371 commented 1 year ago

klay_getRewards() invariant test

[x] check if klay_getRewards() stick to the invariant minted + totalFee - burntFee = proposer + stakers + kgf + kir
- [x] when stakes are [5m+1, 5m+6, 5m]

blukat29 commented 1 year ago

Check API for fund name changes

[x] klay_getRewards() returns kff kcf only
[x] governance_getStakingInfo() returns both PocAddr KIRAddr and kffAddr kcfAddr

aidan-kwon commented 1 year ago

Treasury Rebalancing Test

local test @blukat29 @ian0371 @aidan-kwon

Goal

To test that governance.vote & address book update (kcf/kff) & treasury rebalance happen at block 630.

Environment setup

Homi, docker, 4CN, [7m,6m,5m,4m] stakes.
Genesis config
- stakingupdateinterval = 30
- istanbul.epoch = 210
- magmablock = 0
- koreblock = 630
- kgp103block = 630

Action Plan

0~500
- setup AddressBook with KGF/KIR
- setup KCF, KFF, TreasuryRebalance (code from #1803)
210~420: vote(reward.ratio, 50/30/20)
570~600: AddressBook.submitUpdateXX (KCF, KFF)
629~631: Observe balance changes

Results

Balances (format: balance at [hf-1, hf, hf+1])

Retirees
- [ 3172099074091750000000n, 0n, 0n ]
- [ 1482688683131500000000n, 0n, 0n ]
Newbies
- [ 0n, 800000000000000000000n, 802880000000000000000n ]
- [ 0n, 800000000000000000000n, 801920000000000000000n ]

At hf, newbies have 800 KLAY At hf+1, newbies have 800 KLAY + reward (9.6 0.3 and 9.6 0.2, resp.)

getStakingInfo

> klay.getStakingInfo(630)
{
  KIRAddr: "0x9fe46736679d2d9a65f0992f2272de9f3c7fa6e0",
  PoCAddr: "0xe7f1725e7734ce288f8367e1bb143e90bb3f0512",
  blockNum: 570,
  councilNodeAddrs: ["0xd65c90c979211dbce62a4384bdd3c5e0b0f34d56", "0x82f0aa2d51455c65a10dcb1e7b6e3e4667d202d3", "0xf209d5624329e65a5d1a2507314a74f2a433422a", "0x317c4418007c8825ca7d3b85aef4f03ba3a4fdea"],
  councilRewardAddrs: ["0xd65c90c979211dbce62a4384bdd3c5e0b0f34d56", "0x82f0aa2d51455c65a10dcb1e7b6e3e4667d202d3", "0xf209d5624329e65a5d1a2507314a74f2a433422a", "0x317c4418007c8825ca7d3b85aef4f03ba3a4fdea"],
  councilStakingAddrs: ["0x2279b7a0a67db372996a5fab50d91eaa73d2ebe6", "0xa51c1fc2f0d1a1b8494ed1fe312d7c3a78ed91c0", "0x959922be3caee4b8cd9a407cc3ac1c251c2007b1", "0xc6e7df5e7b4f2a278906862b61205850344d4e7d"],
  councilStakingAmounts: [7000000, 6000000, 5000000, 4000000],
  gini: -1,
  kcfAddr: "0x9fe46736679d2d9a65f0992f2272de9f3c7fa6e0",
  kffAddr: "0xe7f1725e7734ce288f8367e1bb143e90bb3f0512",
  useGini: false
}
> klay.getStakingInfo(631)
{
  KIRAddr: "0xdc64a140aa3e981100a9beca4e685f962f0cf6c9",
  PoCAddr: "0xcf7ed3acca5a467e9e704c703e8d87f634fb0fc9",
  blockNum: 600,
  councilNodeAddrs: ["0xd65c90c979211dbce62a4384bdd3c5e0b0f34d56", "0x82f0aa2d51455c65a10dcb1e7b6e3e4667d202d3", "0xf209d5624329e65a5d1a2507314a74f2a433422a", "0x317c4418007c8825ca7d3b85aef4f03ba3a4fdea"],
  councilRewardAddrs: ["0xd65c90c979211dbce62a4384bdd3c5e0b0f34d56", "0x82f0aa2d51455c65a10dcb1e7b6e3e4667d202d3", "0xf209d5624329e65a5d1a2507314a74f2a433422a", "0x317c4418007c8825ca7d3b85aef4f03ba3a4fdea"],
  councilStakingAddrs: ["0x2279b7a0a67db372996a5fab50d91eaa73d2ebe6", "0xa51c1fc2f0d1a1b8494ed1fe312d7c3a78ed91c0", "0x959922be3caee4b8cd9a407cc3ac1c251c2007b1", "0xc6e7df5e7b4f2a278906862b61205850344d4e7d"],
  councilStakingAmounts: [7000000, 6000000, 5000000, 4000000],
  gini: -1,
  kcfAddr: "0xdc64a140aa3e981100a9beca4e685f962f0cf6c9",
  kffAddr: "0xcf7ed3acca5a467e9e704c703e8d87f634fb0fc9",
  useGini: false
}

chain config

> klay.getChainConfig(630)
{
  chainId: 2019,
  deriveShaImpl: 2,
  ethTxTypeCompatibleBlock: 0,
  governance: {
    govParamContract: "0x0000000000000000000000000000000000000000",
    governanceMode: "single",
    governingNode: "0xd65c90c979211dbce62a4384bdd3c5e0b0f34d56",
    kip71: {
      basefeedenominator: 20,
      gastarget: 30000000,
      lowerboundbasefee: 25000000000,
      maxblockgasusedforbasefee: 60000000,
      upperboundbasefee: 750000000000
    },
    reward: {
      deferredTxFee: true,
      kip82ratio: "20/80",
      minimumStake: 5000000,
      mintingAmount: 9600000000000000000,
      proposerUpdateInterval: 30,
      ratio: "50/30/20",
      stakingUpdateInterval: 30,
      useGiniCoeff: false
    }
  },
  istanbul: {
    epoch: 210,
    policy: 2,
    sub: 13
  },
  istanbulCompatibleBlock: 0,
  kip103CompatibleBlock: 630,
  kip103ContractAddress: "0x5fbdb2315678afecb367f032d93f642f64180aa3",
  koreCompatibleBlock: 630,
  londonCompatibleBlock: 0,
  magmaCompatibleBlock: 0,
  unitPrice: 25000000000
}

CN logs

homi-output-CN-0-1  | INFO[03/17,08:12:19 Z] [24|consensus/istanbul/backend/engine.go:521]    successfully executed treasury rebalancing (KIP-103)  memo="{\"retired\":{\"0x9fe46736679d2d9a65f0992f2272de9f3c7fa6e0\":1484608683131500000000,\"0xe7f1725e7734ce288f8367e1bb143e90bb3f0512\":3174979074091750000000},\"newbie\":{\"0xcf7ed3acca5a467e9e704c703e8d87f634fb0fc9\":800000000000000000000,\"0xdc64a140aa3e981100a9beca4e685f962f0cf6c9\":800000000000000000000},\"burnt\":3059587757223250000000,\"success\":true}"
homi-output-CN-0-1  | INFO[03/17,08:12:19 Z] [24|consensus/istanbul/backend/engine.go:521]    successfully executed treasury rebalancing (KIP-103)  memo="{\"retired\":{\"0x9fe46736679d2d9a65f0992f2272de9f3c7fa6e0\":1484608683131500000000,\"0xe7f1725e7734ce288f8367e1bb143e90bb3f0512\":3174979074091750000000},\"newbie\":{\"0xcf7ed3acca5a467e9e704c703e8d87f634fb0fc9\":800000000000000000000,\"0xdc64a140aa3e981100a9beca4e685f962f0cf6c9\":800000000000000000000},\"burnt\":3059587757223250000000,\"success\":true}"

Baobab single node test @aidan-kwon

klaytn / klaytn

QA for v1.10.2 #1802

Protocol Upgrade

1809

1810

1812

Improvements

1764

1769

1747

1748

1733

1767

1772

1779

1782

1783

1785

1791

1787

1762

1778

1789

1792

1786

Fixes

1766 - @ian0371

1771 - @ian0371

1765 - @kjeom

Misc

1745

1757

1768

Regular tests

Other updates

[ ] Caver js/java test:

Treasury Rebalancing Test

Goal

Environment setup

Action Plan

Results