fix rosetta-klaytn for klaytn v1.10.1

JayChoi1736 commented 1 year ago

Fixes

fix check:data logic in rosetta-klaytn for Kore HardFork
use klay_getRewards API for simple reward calculation.

Caution

The block number at which governance voting is applied is different between v1.9.1 and v1.10.1. However, before Kore Hardfork, it is difficult to check which version of klaytn node the block was created on at the Rosetta Client Therefore, it is assumed that governance voting prior to Kore Hardfork was conducted in versions prior to v1.9.1, and governance voting after Kore Hardfork is assumed to be conducted in versions 1.10.1 or later.

Localnet Test

Environment Klaytn : v1.10.1 Hardforks :

"istanbulCompatibleBlock": 0,
"londonCompatibleBlock": 10,
"ethTxTypeCompatibleBlock": 20,
"MagmaCompatibleBlock": 30,
"KoreCompatibleBlock": 1200, Governance changes

+--------------------+--------------------------------+--------+
|  CHECK:DATA TESTS  |          DESCRIPTION           | STATUS |
+--------------------+--------------------------------+--------+
| Request/Response   | Rosetta implementation         | PASSED |
|                    | serviced all requests          |        |
+--------------------+--------------------------------+--------+
| Response Assertion | All responses are correctly    | PASSED |
|                    | formatted                      |        |
+--------------------+--------------------------------+--------+
| Block Syncing      | Blocks are connected into a    | PASSED |
|                    | single canonical chain         |        |
+--------------------+--------------------------------+--------+
| Balance Tracking   | Account balances did not go    | PASSED |
|                    | negative                       |        |
+--------------------+--------------------------------+--------+
| Reconciliation     | No balance discrepancies were  | PASSED |
|                    | found between computed and     |        |
|                    | live balances                  |        |
+--------------------+--------------------------------+--------+

+--------------------------+--------------------------------+------------+
|     CHECK:DATA STATS     |          DESCRIPTION           |   VALUE    |
+--------------------------+--------------------------------+------------+
| Blocks                   | # of blocks synced             |       6501 |
+--------------------------+--------------------------------+------------+
| Orphans                  | # of blocks orphaned           |          0 |
+--------------------------+--------------------------------+------------+
| Transactions             | # of transaction processed     |       6716 |
+--------------------------+--------------------------------+------------+
| Operations               | # of operations processed      |     204308 |
+--------------------------+--------------------------------+------------+
| Accounts                 | # of accounts seen             |         62 |
+--------------------------+--------------------------------+------------+
| Active Reconciliations   | # of reconciliations performed |     203659 |
|                          | after seeing an account in a   |            |
|                          | block                          |            |
+--------------------------+--------------------------------+------------+
| Inactive Reconciliations | # of reconciliations performed |        992 |
|                          | on randomly selected accounts  |            |
+--------------------------+--------------------------------+------------+
| Exempt Reconciliations   | # of reconciliation failures   |          0 |
|                          | considered exempt              |            |
+--------------------------+--------------------------------+------------+
| Failed Reconciliations   | # of reconciliation failures   |          0 |
+--------------------------+--------------------------------+------------+
| Skipped Reconciliations  | # of reconciliations skipped   |         10 |
+--------------------------+--------------------------------+------------+
| Reconciliation Coverage  | % of accounts that have been   | 91.935484% |
|                          | reconciled                     |            |
+--------------------------+--------------------------------+------------+

Baobab Test

check:data for hardfork / governance change durations
API test by postman

kjhman21 commented 1 year ago

@JayChoi1736 Did you know this statement in KIP-82?

In addition to changing the reward structure, this renewal will include burning the gas fee up to a threshold which is the size of block proposer reward. If the gas fee exceeds the threshold, remaining amount is rewarded to the block proposer. The KGF and KIR portion will be excluded from the gas fee.

JayChoi1736 commented 1 year ago

@JayChoi1736 Did you know this statement in KIP-82?

In addition to changing the reward structure, this renewal will include burning the gas fee up to a threshold which is the size of block proposer reward. If the gas fee exceeds the threshold, remaining amount is rewarded to the block proposer. The KGF and KIR portion will be excluded from the gas fee.

yes. txfee burn scenario has been tested in both case.

klaytn / rosetta-klaytn