klayveR / xenontrade

Path of Exile trading app for price checking and trade whisper management
MIT License
117 stars 23 forks source link

Implemented option to use different providers for checking item prices #41

Closed ForsakenNGS closed 5 years ago

ForsakenNGS commented 5 years ago

I was already working on this for a few weeks, but after the poeprices.info api went down for multiple days (making this tool mostly unusable) I took the time this weekend and polished it as much as possible. It should leave the current functionality unchanged, but provide the option to use alternative providers in case of a downtime. In addition to that the "PoeData" class and extended item parser allows to get more detailed information about mod rolls and the item in general, which allows to provide additional information (e.g. notify about max rolls) and chances to improve the current workflow (e.g. automatically obtain league names, refine price estimates or fallback to different providers)

If there are any issues with my code, feel free to tell me about it and I will look into it as soon as I can. If you want to use this code for other projects, feel free to do so.

klayveR commented 5 years ago

Sound great, good work! I'll check it out as soon as possible, hopefully I'll have it merged by tomorrow.

Thank you so much for your contribution!

ForsakenNGS commented 5 years ago

I actually noticed a few changes I'd like to make in order to simplify the code on your side, therefore leave it for now. Things I will change in the next few days before creating an updated merge request:

klayveR commented 5 years ago

Sounds great! I wrote a module for the official API and one for even more in-depth itemtext parsing which I planned to use for XenonTrade a while ago. If you like we could collaborate on those modules, I think I even have them written in typescript somewhere. I'd love to chat about this. In case you have Discord my tag is klayveR#5312, feel free to add me if you want.

Thanks again, your contribution really motivates me to pick this up again as soon as I can!