search

klazuka / elm-hot-webpack-loader

Webpack loader providing hot code swapping for Elm
MIT License
53 stars 6 forks source link

Update peer deps #21

Open simonh1000 opened 3 years ago

simonh1000 commented 3 years ago

The peerDeps declaration conflicts with using elm-webpack-loader on webapck5 systems. But it looks as though your code works perfectly fine with the 8.0.0 and its just the declaration that needs updating

ronanyeah commented 3 years ago

@klazuka Would you accept a PR for this?

klazuka commented 3 years ago

Yes, that would be appreciated.

On Wed, Apr 14, 2021 at 8:46 PM Rónán @.***> wrote:

@klazuka https://github.com/klazuka Would you accept a PR for this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/klazuka/elm-hot-webpack-loader/issues/21#issuecomment-819940049, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAUULPSBENXBI5QLCWSIC3TIYZNTANCNFSM42GQWZOQ .

ronanyeah commented 3 years ago

In progress: https://github.com/ronanyeah/elm-hot-webpack-loader/commit/324969a5a68f7d6d9e684a885e361578ef052221

robinheghan commented 3 years ago

I got this working in #38

simonh1000 commented 3 years ago

Awesome - everything just worked when you updated all the libs?

robinheghan commented 3 years ago

Pretty much. Just had to update the test project so it would work with webpack 5, which took some trial and error.

kraklin commented 3 years ago

@klazuka - any plan for the merge? With node 16.x and npm 8 the npm install throws errors that there are incompatible versions in peer-dependencies for elm-hot-webpack-loader and elm-webpack-loader.

Workaround to get around those errors is to use --legacy-peer-deps flag while installing this package

npm install --save-dev --legacy-peer-deps elm-hot-webpack-loader
ronanyeah commented 2 years ago

I have published this: https://www.npmjs.com/package/elm-reloader Here's an example usage: https://github.com/ronanyeah/elm-webpack