Fix #62 Added path as key[0] for MultiMapper

klbostee / dumbo

Python module that allows one to easily write and run Hadoop programs.

http://projects.dumbotics.com/dumbo

1.04k stars 146 forks source link

Fix #62 Added path as key[0] for MultiMapper #63

Closed mshevelev closed 11 years ago

mshevelev commented 12 years ago

Please check the fix. Please note that there is small incompatibility with previous versions, i.e. if somebody uses keys in multimappers, however this is very rare. Now a developer will have access to filepaths and should implicitly ignore them if he os she wants...

klbostee commented 12 years ago

Using the keys in multimappers is not that rare actually. Not keen on introducing this backwards-incompatibility to be honest. There must be a better way of fixing this...

klbostee commented 11 years ago

So going to close this pull requests as it's probably a bad idea to introduce this backwards incompatibility. I'm open to alternative solutions though.