search

klean2050 / ecg-augmentations

ECG time-series augmentations library
MIT License
24 stars 2 forks source link

Fixed signal sampling rate #1

Closed ansariyusuf closed 1 year ago

ansariyusuf commented 1 year ago

Hi,

Thank you for initiating this repo. It is much needed in the PyTorch space. I was playing with the mask transforms and noticed that you had fixed the sampling of the ECG signals. However, this has to be an argument from the user depending on the ECG signal he/she is working with.

Am I missing something? Kindly clarify at the earliest.

Yusuf

klean2050 commented 1 year ago

Thank you Yusuf,

You are correct, I am gonna push a set of new changes over the next week, among them the sampling rate argument.

ansariyusuf commented 1 year ago

Sounds great! Let me know when you push the new set of changes so that I can reflect it in my workspace.

klean2050 commented 1 year ago

Just pushed a set of changes, hope yours is fixed. You are also welcome ro contribute with pull requests.

ansariyusuf commented 1 year ago

Thank you, I will keep in mind to make a pull request and push add new features.