klee-contrib / focus-components

Version 2. A set of web components based on material design to build modern interfaces easily. New version 3 is available
https://github.com/get-focus
MIT License
27 stars 34 forks source link

Fix of uncontrolled input #1532

Open xuaveneg opened 6 years ago

xuaveneg commented 6 years ago

When undefined is passed as the checked props of the input, this one is considered as uncontrolled, and an uncontrolled component sometimes cannot change its value via React, resulting in an input which changes cannot be controlled by focus. Passing '' instead of undefined fix this error.

Hartorn commented 6 years ago

@xuaveneg Could you test with true false instead of checked undefined ?

xuaveneg commented 6 years ago

Just tested, it works with true false.