search

klee / klee-web

KLEE in the browser
Other
48 stars 15 forks source link

Fixed CircleCI ubuntu image version and merged dependabot branches #185

Closed kt218 closed 2 years ago

andronat commented 2 years ago

Hey @kt218 may I please ask you to squash all of the commits together with an explanation on the updates?

ccadar commented 2 years ago

@kt218 Was this only issue with CircleCI the ubuntu image? If so, I would do this separately and then merge the dependabot PRs separately.

ccadar commented 2 years ago

@kt218 let's try to merge this, can you push it again? Not sure why the checks haven't run.

kt218 commented 2 years ago

@ccadar I've tried doing a different merge request but it appears that it doesn't perform the check either.

ccadar commented 2 years ago

@ccadar I assume something change on Circle CI's side.
Can you look at https://circleci.com/docs/2.0/troubleshooting-common-issues/ ?

kt218 commented 2 years ago

@ccadar I think I triggered the check now, by manually doing it through CircleCI ui and it appears there's an issue with the last line in config.yml

ccadar commented 2 years ago

Do you know how to fix that line?

kt218 commented 2 years ago

@ccadar I'm unsure about the issues, it looks like it's related to apt-get and some repository issue. I'm trying some changes to see if it will fix the issue.

ccadar commented 2 years ago

I think there are two issues here: the CI failing (which might be fixed by your changes) and the CI not being triggered at all. Right?

kt218 commented 2 years ago

Yes, there's 2 issues. I'm still unable to fix the 1st issue. I'm looking around to see why apt-get is interfering with ansible. As for CI not getting automatically triggered, it might be some setup on CircleCI side that not entirely fixed from the last time the api key was changed.

ccadar commented 2 years ago

@kt218 I think I solved the issue of the CI not being triggered from the CircleCI UI. But I'm still confused as to why there are two checks, "workflow" and "ci/circleci:build"

kt218 commented 2 years ago

I think they are the same, since ci/circle: build is under workflow when looking through the Checks tab on github.

kt218 commented 2 years ago

@ccadar It's a bit ugly but I've resolved the first issue with CI failing, by making sure that the CI always grabs the latest public key for heroku.

ccadar commented 2 years ago

Great! Just squash the commits to config.yml and we can merge it

kt218 commented 2 years ago

@ccadar Commits squashed to config.yml

ccadar commented 2 years ago

@kt218 Don't close the dependabot PRs for now; I'd like to understand why the CI does not trigger for forked repositories.