search

klei / grunt-injector

Inject references to files into other files (think scripts and stylesheets into an html file)
MIT License
106 stars 38 forks source link

added a type attribute to the script tag returned by transform #22

Closed mikedeswert closed 9 years ago

mikedeswert commented 9 years ago

I added the type attribute to make it wcm compliant. Was there a specific reason to let it out? My webapp didn't like the fact that the attribute was missing and the browser kept reloading the scripts.

joakimbeng commented 9 years ago

This is the reason: http://stackoverflow.com/a/14323399

What doctype are you using in your app?

mikedeswert commented 9 years ago

I found out, that there was a different root cause for the issue I was having (unrelated to the scripts injected).

I didn't know the type attribute had become redundant, the more you know ... :)

You can ignore the pull request if you want, thanks for the reply.

Kind regards, Mike

On 30 Mar 2015, at 12:37, Joakim Carlstein notifications@github.com wrote:

This is the reason: http://stackoverflow.com/a/14323399

What doctype are you using in your app?

— Reply to this email directly or view it on GitHub.