Open Toilal opened 9 years ago
@joakimbeng do you have a opinion on that ? :smiley:
Sorry for my slow response :P
I think you're right. Do you think it should log anything when a syntax error is found, or be totally quiet?
In my opinion a gulp plugin shloud parse argv to catch the --verbose
option of cli cmd gulp
.
Like https://github.com/zckrs/gulp-css-base64/blob/master/src/index.js#L31
See comment
I'm not sure it should depend on --verbose
flag because it's an error. It should be logged maybe at warning level.
Here's the handling of the same issue in gulp-sass by passing in an option {errLogToConsole: true}: http://blog.ionic.io/fixing-a-broken-sass-build-stream/
Came across a issue where if you try to sort a stream of files where you have both your js and css the lib will fail silently.
Example:
gulp.src(['./src/**/*.js', './src/**/*.css'], {read: false});
I don't think it should even fail, don't parse non js files.
https://github.com/klei/gulp-angular-filesort/blob/master/index.js#L24
Does this make sense to through this error instead of continuing ? If there is about 100 javascript files to sort, why breaking the whole processing just because of one file ?