search

klei / gulp-angular-filesort

Automatically sort AngularJS app files depending on module definitions and usage
MIT License
132 stars 46 forks source link

Initial Alphabetic Sorting #50

Closed Thomasvdam closed 8 years ago

Thomasvdam commented 8 years ago

Hey there,

We've been using this plugin on some projects where setting up Webpack/Broweserify didn't seem worthwhile. The only gripe we have is that the ordering of files seems non-deterministic besides the module definition. This creates pointless changes in git when switching branches for example, which can be annoying. To avoid this I sort the files alphabetically first before the dependency sorting.

I also updated the dependencies and added a editorconfig, hope this is not too much.

Kind regards

erikdonohoo commented 8 years ago

Please please this. This plugin is awesome but the fact that I get two different orderings on the exact same code just seems so strange and annoying as far as git is concerned.

hgwood commented 8 years ago

I have switched to @Thomasvdam's fork.

hgwood commented 8 years ago

@Thomasvdam Could you upgrade your fork to ng-dependencies 0.7, in order to get https://github.com/klei/ng-dependencies/pull/13?

joakimbeng commented 8 years ago

Thanks! This is great :)

When the ng-dependencies is bumped in package.json as @hgwood suggests I will merge...

Thomasvdam commented 8 years ago

I bumped the dependency, if there's anything else I can do let me know. :)

Thomasvdam commented 8 years ago

Hey @joakimbeng, sorry for bringing this up again. I must admit I had kind of forgotten about this pull request, but with it being Hacktoberfest and all would you mind looking over the changes again? 😀

joakimbeng commented 8 years ago

I'm so sorry. I had forgotten about this as well!

Looking good, thank you so much!

Thomasvdam commented 8 years ago

Thanks for taking the time to come back to it, much appreciated. :)