search

kleijnweb / php-api-hydrator

*DEPRECATED*
GNU Lesser General Public License v3.0
1 stars 2 forks source link

Fix Deserializing scalar date times #1

Closed vitormv closed 7 years ago

vitormv commented 7 years ago

When deserializing values, this class was applying a default datetime format, instead of using the one that was passed to the constructor of this class. Swagger API for example, allows to have extremely precise DateTime that include DateTime::RFC3339, but also allows for adding microseconds.

When deserializing such values, this class would lose that precision, as it was not taking into account the custom format.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling c01a2461e2415086d2a4d6a4e397a96d132ccf79 on vitormv:fix-date-deserialize-format into 1bb2e7edb6b433bda212eb5db4736a5c45faa1ae on kleijnweb:master.

kleijnweb commented 7 years ago

Something weird is going on with Travis, but local test confirms coverage at 100%. And this looks fine. Thanks.

kleijnweb commented 7 years ago

See https://github.com/kleijnweb/swagger-bundle/issues/93, coveralls is reporting 100% again. GitHub badge will take some time.