Bugfix - PHPUnit upgrade and output buffer fixes

klein / klein.php

A fast & flexible router

MIT License

2.66k stars 290 forks source link

Bugfix - PHPUnit upgrade and output buffer fixes #340

Closed Rican7 closed 7 years ago

Rican7 commented 7 years ago

This PR updates PHPUnit to the highest stable version that we can use given our PHP runtime version constraints.

During the upgrade, thanks to PHPUnit's new "risky" test detection, I noticed a few problematic areas regarding the output buffer handling in Klein. I've cleaned them up and fixed a potential miss-handling of output buffer stacking.

Win win. 😃

Rican7 commented 7 years ago

Woot! All green! Merging...

Rican7 commented 7 years ago

This fixes #268.