search

kleinerm / Psychtoolbox-3

This is kleinerm's git repository for development of Psychtoolbox-3. Regular end users should stay away from it, unless instructed by him otherwise, and use the official Psychtoolbox-3 GitHub page or distribution system for production releases.
104 stars 304 forks source link

Typos found by codespell #212

Closed DimitriPapadopoulos closed 2 years ago

DimitriPapadopoulos commented 2 years ago

This patch restricts itself to the following folders and fixes 54 out of 3552 reported typos (some of which might be false positives of course):

Would you be willing to accept further fixes of typos found by codespell?

kleinerm commented 2 years ago

Thanks for these!

I would accept further fixes, if they are safe and non-intrusive and don't break the general development workflow. It is a nice to have quality improvement, but I am very time constrained and overworked, being essentially the only maintainer and developer, and always buried in work. We don't have any CI atm., and most important stuff needs special hardware and a human in the loop anyway, so it is human in the loop manual testing of everything on different OS+runtime environment+hardware, "as needed". So i'd rather leave typos in place if there is any change they could break code or the flow of development, e.g., due to merge conflicts, or introduce bugs.

Probably stuff inside the PsychSourceGL/ subfolder should not be touched. Neither things like GLSL shaders inside the Psychtoolbox folder.

Safe would be changes to help texts / user facing documentation, i guess, like the ones you did in this pull request.

kleinerm commented 2 years ago

Essentially I generally don't have time to review such changes, or to test if they would break anything. So they must be obviously correct and safe to apply in the sense of not breaking behaviour or formatting. I skimmed these, and they looked safe, but with a much larger volume I couldn't. If in doubt, I'd just ignore the pull request or let it sit until the rare time where i have time for such stuff.

Trying to set your expectations right, so there isn't disappointment. You are dealing with a very overworked and time-strapped maintainer here.