kleinerm / Psychtoolbox-3

This is kleinerm's git repository for development of Psychtoolbox-3. Regular end users should stay away from it, unless instructed by him otherwise, and use the official Psychtoolbox-3 GitHub page or distribution system for production releases.
104 stars 306 forks source link

PsychPython: Dropping 2.x support, adding opt-in Limited API support, and cleaning up Python abstractions #232

Closed aforren1 closed 2 years ago

aforren1 commented 2 years ago

Hi Mario,

Here's the follow-up to https://github.com/Psychtoolbox-3/Psychtoolbox-3/pull/766 (only took three months!).

I've reorganized as you recommended, and a few other things:

All the demos work fine on a local Ubuntu 20.04 machine + a Win10 virtual machine, and all platform+Python version combinations are lightly tested during the wheel-building process (see e.g. https://github.com/aforren1/ptb-wheels/actions/runs/2862919054).

kleinerm commented 2 years ago

Ok. But please make these changes quick. This is material for the upcoming 3.0.18 -> 3.0.19 transition, given it breaks backwards compat by removing Python 2. I will release that likely in September.

kleinerm commented 2 years ago

Mostly good, with some small comments. Wrt. the last fixup commit however, I'd like to have the stuff integrated into the previous commits. And no trace of that gpl code in the first place, not even as a commit that gets undone in an immediate followup commit.

kleinerm commented 2 years ago

In the interest of time, as this needs to go into an initial 3.0.19 release and I don't want that release to be held up, i've made the changes i requested myself, and some other minor fixes/cleanups. You can find it as pull request #234. I will merge it once the PTB 3.0.19 release is up.

I've only lightly tested on Ubuntu 20.04 LTS without limited api, ie. if it actually builds, nothing more.

Closing this one. Thanks!