search

kleinfreund / vue-accessible-color-picker

A color picker component for Vue.js 3.
https://vue-accessible-color-picker.netlify.app
MIT License
115 stars 8 forks source link

Types for typescript #6

Closed j-d-carmichael closed 3 years ago

j-d-carmichael commented 3 years ago

Looks way cleaner and easier to use than vue-color but cannot use as there are no types - it is this already in progress?

kleinfreund commented 3 years ago

I do want to add types to the project, yes. I’m also considering to write it in TypeScript entirely but for that, I want to finish the migration to Vue.js 3 first. The migration to Vue.js 3 is currently blocked on a couple of issues documented in https://github.com/kleinfreund/vue-accessible-color-picker/issues/4 so this will have to wait.

I’ll have a look at what I can do to expose type definitions for the project with the current major version 1.

kleinfreund commented 3 years ago

I added some basic type definitions to the project in v1.1.0. Many parts of the code base were also covered with type annotations. The currently existing type definitions should be sufficient to annotate most things in relation to this plugin, but I don’t consider this work to be quite done, yet. I will see how the typing situation can be improved both in the source code and for package consumers.