search

kleisauke / net-vips

.NET binding for libvips.
https://kleisauke.github.io/net-vips/
MIT License
383 stars 31 forks source link

Dz different folder structure #235

Open feelgood-interface opened 1 week ago

feelgood-interface commented 1 week ago

Since the change of the dzsave library (https://github.com/libvips/libvips/issues/3354) the folder structure is different.

  1. Previously when saving as a ZIP the folder structure was: basename/basename_files/... Now it is: basename_files/... Will this now be the default folder structure?
  2. The modified timestamp of the files is incorrectly set to1980-01-01 00:00, but this is probably related to the libarchive library.
kleisauke commented 1 week ago

Hi @feelgood-interface,

I believe the previous folder structure was necessary because libgsf required a parent directory for writing, see e.g. PR: https://github.com/libvips/libvips/pull/465

Which was more or less a workaround, I believe we have now decided to use this "new" folder structure as the default. (/cc @jcupitt)

As for point 2, this can be useful to create deterministic ZIP files, see for example the test script in PR: https://github.com/libvips/libvips/pull/3687

jcupitt commented 1 week ago

Hello Kleis and @feelgood-interface, yes, the previous folder structure was forced on us and the new structure is the one we plan to stick to if we possibly can.