search

kleisauke / wasm-vips

libvips for the browser and Node.js, compiled to WebAssembly with Emscripten.
https://kleisauke.github.io/wasm-vips/
MIT License
463 stars 25 forks source link

Run Docker interactively #32

Closed RReverser closed 1 year ago

RReverser commented 1 year ago

This allows for Ctrl+C to work.

kleisauke commented 1 year ago

FWIW, it looks like this doesn't seem to work on CI, see for example: https://github.com/kleisauke/wasm-vips/actions/runs/3628866537/jobs/6120437544

Commit https://github.com/kleisauke/wasm-vips/commit/02d0b97a9afa751a6789bbe4403fd99b14caa4cc and this PR used the cache from the previous run (i.e. it didn't run npm run build), hence it went unnoticed. Sorry for not catching this earlier.

Perhaps the CI should use an other npm script (or simply issue these Docker commands in non-interactive mode)?

kleisauke commented 1 year ago

... commit https://github.com/kleisauke/wasm-vips/commit/9f6cc94a2a2d116cc6c75aaedc7f57793d74eb00 fixes this.

I also considered adding package.json to the cache invalidate list, but that doesn't make a lot of sense after that commit (+ that would cause unnecessary builds on tagged commits). :)

RReverser commented 1 year ago

FWIW, it looks like this doesn't seem to work on CI, see for example:

Hm, that's unfortunate.