klembot / twinejs

Twine, a tool for telling interactive, nonlinear stories
https://twinery.org
GNU General Public License v3.0
2k stars 295 forks source link

Unclear when navigating to story format list that you have changed view #1051

Open svatas opened 2 years ago

svatas commented 2 years ago

Describe the bug.

When I was trying to add a new story/proofing format I found inconsistency in tab menu in top of window. When it happend I was unable to use the tab menu as expected, just Back button and choosing again the finction will work.

Steps to reproduce:

  1. Open Twine - Story Formats, submenu will appear (+Add, Remove, Disable Editor Extensions…) and all formats listed
  2. Click to Twine and submenu will appear (Preferences, Story Formats, About…) and all formats still listed. Button Story Formats is grayed and not usable informing that Story format window is vissible, but controls for it are not available. The control menu in tab for Story format window is covered by menu for Twine. It is unusable for Story Format window
  3. The only possibility to see the proper menu is to click to Back button and the choose again Twine - Story format.

Looks like the Story Formats item opens specific view with specific menu in tab and therefore not handled properly. No other item in menu is same type and behaves the same.

Expected behavior:

Proper menu for Story Formats window should be visible

Additional context on this problem.

No response

Twine version number

2.4.0 beta-2

Does this problem occur with the web version of Twine or the desktop app?

Desktop app

What operating system does this problem occur on?

Windows

If this problem is occurring with the web version of Twine, what browser does it occur on?

No response

Presubmission checklist

klembot commented 2 years ago

I'm confused a little bit by this description. The behavior I see is:

I don't see the Story Formats tab at the top becoming unselectable. Could you clarify?

svatas commented 2 years ago

I think tha main confusion comes from the fact, that when you will see the Story list (You activated tab Story Format) and going back to tab item Twine, the Story Format item is disabled and user can have the feeling it is not working as they will not recgnize the tab Story Format. Because when you were there for the first time, the Story Format button on tab Twine was available and after some time it is not available. This was comment of one of users I discussed this.

In this case I suggest to hide the VIiew and Twine menu item on Tab.

svatas commented 2 years ago

Animation to show what is mentioned Issue1051_anim

greyelf commented 2 years ago

So based on your supplied image the issue appears to be that the end-user can interact with "top most" tab menu before they have selected the "Back" option to exit out of the selected "Current Story Formats" panel.

So maybe the answer is to disable/hide the "View" and "Twine" items in the "top most" tab menu until the end-user has selected "Back" to exit the "Current Story Formats" panel.

klembot commented 2 years ago

I think I follow you now. It sounds like the issue is people are not realizing they've moved to another part of the UI when selecting "Story Formats" in the toolbar. Part of the confusion is that the window title is not changing, which is fixed in #1031. It might also be fixable with some kind of transition animation to better signal "you have navigated somewhere else".