klembot / twinejs

Twine, a tool for telling interactive, nonlinear stories
https://twinery.org
GNU General Public License v3.0
2k stars 296 forks source link

.DS_Store in browser bundle #1197

Open dfghjkjhgr opened 2 years ago

dfghjkjhgr commented 2 years ago

Describe the bug.

In the .zip file bundle for Twine, there is a .DS_Store file in it. I’m assuming it wasn’t caught by the .gitignore file you have set up. I see that there is a *.DS_Store rule in the .gitignore, but .DS_Store is a dot file, so it doesn’t work.

Steps to reproduce:

Download the twine browser.zip file. Unzip it. You should see a .DS_Store file. Try showing hidden files

Expected behavior:

I expected there to be no .DS_Store file, because it can leak private info about contributor’s PCs.

Additional context on this problem.

No response

Twine version number

2.4.0

Does this problem occur with the web version of Twine or the desktop app?

Web

What operating system does this problem occur on?

Other

If this problem is occurring with the web version of Twine, what browser does it occur on?

Other

Presubmission checklist

klembot commented 2 years ago

I see the issue... it seems like .DS_Store files get created somehow in the release process, even if I delete the dist directory before running it. So the web zip process should delete that file before archiving.