https://twinery.org/2/favicon.ico is missing

webbedspace commented 1 year ago

Describe the bug.

The web version of Twine 2 has a broken favicon. It references ./favicon.ico instead of ../favicon.ico. I understand this is technically a twinery.org bug, but it's hard to tell which repo to put this issue.

Twine version number

2.5.1

Does this problem occur with the web version of Twine or the desktop app?

Web

What operating system does this problem occur on?

Windows

If this problem is occurring with the web version of Twine, what browser does it occur on?

Firefox

Presubmission checklist

[ ] I am interested in working on code that would fix this bug. (This is not required to submit a bug report.)
[X] I have done a search and believe that an issue does not already exist for this bug in the GitHub repository.
[X] I have read and agree to abide by this project's Code of Conduct.

klembot commented 1 year ago

This is an omission in the 2.3 -> 2.4 transition--I think it's best if the app and hosting site don't share resources to avoid a change on one side breaking the other, so the answer in my opinion is to add favicons to the app.

webbedspace commented 1 year ago

Quick question, does the "good first issue" label imply that PRs are wanted for it (i.e. similar to "help wanted")?

klembot commented 1 year ago

Yes. I was thinking this one's a quick fix and so someone new to the codebase would be able to resolve it fairly easily.

klembot / twinejs