klembot / twinejs

Twine, a tool for telling interactive, nonlinear stories
https://twinery.org
GNU General Public License v3.0
1.86k stars 288 forks source link

[2.6] CodeMirror errors when opening passages in Harlowe (minor) #1361

Open hituro opened 1 year ago

hituro commented 1 year ago

Describe the bug.

When opening a passage editor in Harlowe (3.3.4), the following errors are logged:

use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.41" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.42" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.43" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.46" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.47" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.48" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.410" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.411" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.412" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.413" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.40.0" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.40.1" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.40.2" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.40.3" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.40.5" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.44.0" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.44.1" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.44.3" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.44.4" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.45.0" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.45.1" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.49.0" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.49.1" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.49.2" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.49.3" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.49.4" command defined, skipping
use-format-codemirror-toolbar.ts:64 CodeMirror already has a "harlowe-3.3.49.6" command defined, skipping

Stack trace for one of these:

  | (anonymous) | @ | use-format-codemirror-toolbar.ts:64
-- | -- | -- | --
  | ls | @ | react-dom.production.min.js:211
  | Ol | @ | react-dom.production.min.js:257
  | t.unstable_runWithPriority | @ | scheduler.production.min.js:19
  | Ko | @ | react-dom.production.min.js:122
  | El | @ | react-dom.production.min.js:257
  | sl | @ | react-dom.production.min.js:239
  | (anonymous) | @ | react-dom.production.min.js:123
  | t.unstable_runWithPriority | @ | scheduler.production.min.js:19
  | Ko | @ | react-dom.production.min.js:122
  | Qo | @ | react-dom.production.min.js:123
  | Yo | @ | react-dom.production.min.js:122
  | R | @ | react-dom.production.min.js:287
  | Yt | @ | react-dom.production.min.js:68

Steps to reproduce:

Open any passage editor in a Harlowe formatted story

Expected behavior:

Presumably, that these warnings do not appear

Additional context on this problem.

I've marked this minor, since you have to have the console open to even see the problem, but it implies something is not working as expected.

Twine version number

2.6

Does this problem occur with the web version of Twine or the desktop app?

Desktop app

What operating system does this problem occur on?

macOS

If this problem is occurring with the web version of Twine, what browser does it occur on?

None

Presubmission checklist

klembot commented 1 year ago

Honestly, the fix probably would be to remove the warnings.