klembot / twinejs

Twine, a tool for telling interactive, nonlinear stories
https://twinery.org
GNU General Public License v3.0
1.98k stars 294 forks source link

[2.6.1] Twine continually recreates an export folder #1388

Open hituro opened 1 year ago

hituro commented 1 year ago

Describe the bug.

At some point in the past I imported a game from a folder called "baodcgame" (I suspect the name is entirely unimportant)

Now, whenever I export or import a game, Twine recreates this folder.

It doesn't matter how many times I have changed the import or export location to somewhere else, or how many times I have deleted the folder itself, or even how many times I have upgraded Twine, the same folder is continually remade.

I am sure the setting is stuck somewhere in the app prefs, and I just want to know how to clear it.

Steps to reproduce:

No idea

Expected behavior:

Twine doesn't keep re-creating the folder

Additional context on this problem.

No response

Twine version number

2.6.1

Does this problem occur with the web version of Twine or the desktop app?

Desktop app

What operating system does this problem occur on?

macOS

If this problem is occurring with the web version of Twine, what browser does it occur on?

None

Presubmission checklist

klembot commented 1 year ago

I wish I had a clue why this is happening, but I don't. Here's the story saving code. It doesn't contain any calls to create folders that I can see. Importing reads the file using a file input which shouldn't have the ability to write anything to disk. I'm going to mark this as help wanted in hopes someone sees something I'm not.

hituro commented 1 year ago

@klembot I suspect the issue is with file-saver. I am experiencing this on MacOS, and that generally points a Save As dialog wherever your last save was. My guess is that it is recreating that directory at that point?

klembot commented 1 year ago

@hituro if that were the case, though, wouldn't it only happen when you export a story, since importing doesn't use that library?

I'm wondering if it is an Electron issue.

hituro commented 1 year ago

@hituro if that were the case, though, wouldn't it only happen when you export a story, since importing doesn't use that library?

I'm wondering if it is an Electron issue.

You are correct. After some more testing, it only happens when I export a game, not when I import. Exporting recreates the directory even if it deleted.