search

klembot / twinejs

Twine, a tool for telling interactive, nonlinear stories
https://twinery.org
GNU General Public License v3.0
2k stars 295 forks source link

SugarCube broken in Twine 2.0.6 #152

Closed klembot closed 6 years ago

klembot commented 9 years ago

Originally reported by: Thomas M. Edwards (Bitbucket: tmedwards, GitHub: tmedwards)

When using Play or Test with any instance or version of SugarCube in Twine 2.0.6, attempting to interact with any clickable produces an error. The line from the console log is:

Uncaught TypeError: Cannot read property 'match' of undefined
klembot commented 9 years ago

Original comment by Tim Samoff (Bitbucket: timsamoff, GitHub: timsamoff):

I’m getting this error now:

Sorry, an error has occurred. Error: There is no passage with the ID or name (http://twinery.org/2/#stories/4b131973-f1cd-eb9a-f12c-37bc2603fa1a/play: 5)

From the Console:

[Error] Error: There is no passage with the ID or name 
    show (2, line 5)
    (anonymous function) (2, line 5)
    (anonymous function) ([native code], line 0)
    dispatch (2, line 2)
    handle (2, line 2)

This was produced using the same two-passage story file that I attached previously.

klembot commented 9 years ago

Original comment by Chris Klimas (Bitbucket: klembot, GitHub: klembot):

Handle elements without href attributes properly in NW.js

Resolves #152

klembot commented 9 years ago

Original comment by Thomas M. Edwards (Bitbucket: tmedwards, GitHub: tmedwards):

I'm using the NW.js version.

klembot commented 9 years ago

Original comment by Chris Klimas (Bitbucket: klembot, GitHub: klembot):

???

I totally believe you're seeing this behavior, but I can't duplicate it on my side. Saves and Restart seem to work fine, no console errors. What browser do you see it on? I tried on Chrome and Firefox latest.

klembot commented 9 years ago

Original comment by Thomas M. Edwards (Bitbucket: tmedwards, GitHub: tmedwards):

Checked passage links in 1.0.23 and they seem to work, so it's not all clickables then. Still, try any of the core UI bar menu items, Saves for example.

klembot commented 9 years ago

Original comment by Chris Klimas (Bitbucket: klembot, GitHub: klembot):

Could you give me an example of passage source that triggers this? Regular passage links work for me, so I suspect you're talking about something more specific.