klembot / twinejs

Twine, a tool for telling interactive, nonlinear stories
https://twinery.org
GNU General Public License v3.0
2k stars 295 forks source link

Story Library sort (View > Sort By) does not correctly sort (Desktop *and* Online) #1521

Closed loopernow closed 3 months ago

loopernow commented 6 months ago

Describe the bug.

On the Story Library screen, sorting by either option (going to View, selecting Sort By, and then choosing either Last Updated or Name in the drop-down menu) does not sort correctly:

This bug occurs in both the desktop app and online.

Steps to reproduce:

I have two stories with titles staring with 'd,' one that starts with 'q,' and one that starts with 't.'

Expected behavior:

When selecting Last Updated, the most recently updated story should be listed first and the least recently updated story should be listed last.

When selecting Name, stories that begin with early letters of the alphabet should be listed before stories that begin with late letters of the alphabet.

Additional context on this problem.

When I select sort by Name, my stories are sorted in order: d, q, d, t.

I don't know if this has any relevance to anything, but the language on my laptop is Spanish (Latin America). Dates in this region are formatted day/month/year. This bug does occur in the browser too, though, and of course with sort by Name too, not just sort by Last Updated.

Twine version number

2.6.0

Does this problem occur with the web version of Twine or the desktop app?

Web

What operating system does this problem occur on?

Windows

If this problem is occurring with the web version of Twine, what browser does it occur on?

Firefox

Presubmission checklist

greyelf commented 5 months ago

Sort by name sorts in no discernible pattern.

When I use the View > Sort By > Name option of my web-browser based release of the Twine v2.8.1 application the projects are sorted Alphabetically, but because the names are letter case-sensitive, those names that start with an upper-case letter come before those that start with a lower- case letter. eg. If the names were "A", "b", "C", "d", then the order they are displayed in are "A", "C", "b", "d"

klembot commented 5 months ago

@loopernow noticed you listed the version you are using as 2.6.0. Can you try with the latest?

klembot commented 5 months ago

Ah, apologies. This was fixed in this PR, but it hasn't seen a release yet: https://github.com/klembot/twinejs/pull/1503

loopernow commented 5 months ago

Sort by name sorts in no discernible pattern.

When I use the View > Sort By > Name option of my web-browser based release of the Twine v2.8.1 application the projects are sorted Alphabetically, but because the names are letter case-sensitive, those names that start with an upper-case letter come before those that start with a lower- case letter. eg. If the names were "A", "b", "C", "d", then the order they are displayed in are "A", "C", "b", "d"

Ah I see, thank you. 👍

klembot commented 3 months ago

Closing now that 2.9.0 is out.