search

klembot / twinejs

Twine, a tool for telling interactive, nonlinear stories
https://twinery.org
GNU General Public License v3.0
2k stars 295 forks source link

Twine installer incorrectly deletes all contents of Twine installation folder during reinstallation #962

Open HiEv opened 2 years ago

HiEv commented 2 years ago

Testing with the Twine v2.3.15 installer and upgrading from v2.3.14, I had set up folders for the current version of SugarCube and the Illume proofing format within the Twine installation folder (in my case, C:\Program Files\Twine), and upon installation those two folders were incorrectly deleted.

Updates should not remove any files which were not created by the previous install. If you want to do cleanup before installation, then a proper uninstall should be done first, which only removes the files created by the previous install, followed by installation.

See this IntFiction.org post which alerted me to the situation, where a user lost data because of this incorrect installation practice.

Please fix the installer ASAP, so as to prevent further data loss, and including the latest version of SugarCube would also be recommended. Fixing the story-formats.json corruption problem (bug #710) would also be nice.

klembot commented 2 years ago

a) Do we know if this is a Windows problem only?

b) I don't know where to start to debug this problem as the installer is created by electron-builder. Configuration is here and as you can see, it is not doing much more than defaults.

So--help very much would be appreciated.

klembot commented 2 years ago

While I'm grooming issues... can we reproduce this with 2.4?