search

klemens / ff-flashdisable

Firefox toolbar button to (de)activate Flash with one click.
5 stars 0 forks source link

Seems to confuse VLC Web Plugin with Flash #11

Open SamB opened 8 years ago

SamB commented 8 years ago

It looks like FlashDisable accidentally disables not only the actual Flash plugin, but also the VLC Web Plugin for some reason. Unfortunately, I can't seem to find the code to actually disable the plugins, so I don't have much clue why this is; my best guess is that it's something to do with the MIME types that VLC's plugin declares support for.

klemens commented 8 years ago

FlashDisable uses the preference plugin.state.flash to disable/enable flash. You could try setting it manually in about:config and see if that also disables the VLC plugin. (0 means disabled, 1 click-to-play and 2 enabled)

klemens commented 8 years ago

It seems you are right, firefox uses the mime type to recognize the flash plugin. The variable eSpecialType_Flash is then used to set mIsFlashPlugin to true which in turn results in the special name flash chosen as a "filename" for the plugin. This is also used for the preferences, plugin.state.flash is this case.

So if the VLC plugin signals that is supports the same MIME types as the real flash plugin, firefox uses the same preference for both plugins. I am surprised that this doesn't cause any other problems.

I am not sure if there is anything I can do about this problem.

SamB commented 8 years ago

@klemens: Ah. I guess I'll have to bug Mozilla about that, then; thanks for pointing me in the right direction. Looks like there's even a specific MIME type they could use to detect that it's actually VLC and not a proper SWF plugin: application/x-vlc-plugin...