search

klemens / ff-flashdisable

Firefox toolbar button to (de)activate Flash with one click.
5 stars 0 forks source link

Add an option in Tools menu to enable or disable flash. #3

Closed popman closed 10 years ago

popman commented 10 years ago

This would be useful to save space on the screen, since Australis did away with the addon bar.

Also, anyone using unity would benefit from it being integrated.

klemens commented 10 years ago

This is probably not an easy task to do because I use the addon-sdk for my addon and so I cannot use the xul-overlay method that is usually used to add an entry to the tools menu.

If you want to save space with australis, you can also drag the button to the australis menu. Currently the button looks a bit blurry then, but this will be fixed in the next version which I will publish soon.

popman commented 10 years ago

Mainly it's for the HUD functionality. Also, it'd seem much more integrated like that.

klemens commented 10 years ago

Ok, it seems I can use https://github.com/mykmelez/menuitems-jplib, which would simplify things.

I will think about it (but cannot promise anything).

klemens commented 10 years ago

I implemented this in 65cc5f1ca29a824bfc90d4433202b3ec1eb15560 and released a new beta: https://github.com/klemens/ff-flashdisable/releases/tag/v1.0.0beta2 It would be very nice if you could test it and tell me if it works for you. I will probably add a setting to enable the menu entry and make it disabled by default.

popman commented 10 years ago

It works. It even changes the menu item's name, so it makes sense both ways. The HUD also works with it.

I'll post another comment if I notice any problems, but the functionality is fine so far.

klemens commented 10 years ago

Today I released version v1.0.0 (not yet reviewed by mozilla) which is identical to the latest beta, so the menu item is included.