search

klemens / ff-youtube-all-html5

Play all videos on YouTube with your preferred settings (size, quality, playback rate, …) without cookies using only HTML5
https://addons.mozilla.org/de/firefox/addon/youtube-all-html5/
34 stars 9 forks source link

Progress bar gets cropped to original size when using larger player #49

Closed outadoc closed 8 years ago

outadoc commented 9 years ago

With the latest stable and beta versions of the add-on, the progress bar gets cropped to whatever the original size was on the HTML5 player. It seems to reset itself every second, too.

screenshot from 2015-03-30 20 25 28

Tested with every video loading method available.

klemens commented 9 years ago

This is a known bug, which I already tried to fix some tome ago (1a90113c92a0f6751fbea81a03d3dc1acf649188). But youtube removed the ability to fix this properly. (24129f79b7213d252fc8f8817047bbef19777f02, 8a0e787d61aa1cd61d625da97c45ccbea051a43b)

I have experimented with some possibilities to fix the display of the progress bar, but this turns out to be quite difficult. While the display itself could be fixed relatively easy, the problem is that this does not fix the player code that calculates the video position when you click on the bar. So clicking positions and displayed position would no longer be in sync. I have tried to "hack" the code and override the sizes, but had no success, so I decided the keep it the way it is. At least it's consistent.

outadoc commented 9 years ago

That sucks. I guess it's still better than nothing, I hope it'll be fixable in the future somehow.

ZatsuneNoMokou commented 8 years ago

Youtube Center (https://github.com/YePpHa/YouTubeCenter) is able to change player size without this problem, if it can help you.

klemens commented 8 years ago

YTC has had a fix right from the beginning, when the new player with programmatically calculated sizes was introduced: https://github.com/YePpHa/YouTubeCenter/issues/1125 But it was very ugly, so I didn't want to include it. (see the already mentioned 8a0e787 for more details)

However I just noticed after looking at the YTC code, that this was obsoleted in 2015-05 when youtube introduced the new transparent player which is still used today. This also enabled the use of a much simpler workaround: https://github.com/YePpHa/YouTubeCenter/issues/1634

I just tested this workaround (disabling the browser-internal function matchMedia) and it seems to work fine, so this will probably be in the next update! Thanks for your reminder. :wink:

ZatsuneNoMokou commented 8 years ago

I'm back using your addon, YTC is... heavier ^^ It's kind of annoying to have the kind of links in video and the preview not at the right place

klemens commented 8 years ago

This is fixed in 84e90556c1ea5c1d9a5450bc0efa8aab37fc6a39, which will be part of version 3.1.0. I will try to release this new version in a few days! :smiley: