added django 1.10 compatibility

klen / django_markdown

Django markdown support and wysiwig

GNU Lesser General Public License v3.0

391 stars 143 forks source link

added django 1.10 compatibility #70

Closed sv0 closed 4 years ago

sv0 commented 8 years ago

Changes:

removed request.REQUEST (replaced with request.POST)
use list of urls instead of 'patterns' in urls.py ( for Django >= 1.8).
'django.conf.urls.patterns()' will be removed in Django 1.10

coveralls commented 8 years ago

Coverage decreased (-0.4%) to 57.778% when pulling 286b12a52eaa8870160d8cff90ad84b529f7d2e9 on sv0:develop into 0c8081b0610bc73c996c15d27aa62b4602c00aee on klen:develop.

coveralls commented 8 years ago

Coverage increased (+5.8%) to 63.983% when pulling e752e221dead85602b522b40609f133e953a7c83 on sv0:develop into 0c8081b0610bc73c996c15d27aa62b4602c00aee on klen:develop.

filipeximenes commented 8 years ago

@sv0 this project seems not be maintained anymore and the owner does not seem interested in even merging PRs or even answering messages. Your PR is very important, you should consider renaming the project and deploying it under this new name to PyPI so we can continue using it (just make sure you keep compatible licences and credits).

Consider the names: django-markdown-fields django-markdown-forms django-markdown-utils

Hope to hear from you!

CostantinoGrana commented 8 years ago

@sv0 I agree with @filipeximenes. Please make your branch an official new project. It works perfectly.

sv0 commented 8 years ago

@filipeximenes @CostantinoGrana OK. I will do it just after returning from the vacation.

sv0 commented 8 years ago

I've created a new repository https://github.com/sv0/django-markdown-app for django-markdown application.

The package is also available on PyPI: https://pypi.python.org/pypi/django-markdown-app

@filipeximenes unfortunately the name django-markdown-utils is already taken. So I've chosen another one. I hope it's OK.

filipeximenes commented 8 years ago

@sv0 Awesome, thanks!