search

klen / django_markdown

Django markdown support and wysiwig
GNU Lesser General Public License v3.0
391 stars 143 forks source link

Django 2.0 #80

Open Ge0 opened 6 years ago

Ge0 commented 6 years ago

Hello there,

Django 2.0 has just been released and the django.core.urlresolvers submodule has been replaced by django.urls. This is a breaking change and we were warned about it since Django 1.7.

The following PR submit snippets that try to import urlresolvers first (for backward compatibility before Django 2.0) then, if it fails, imports django.urls for compatibility with new Django versions.

seenureddy commented 6 years ago

@Ge0 This build is failed because of --use-mirrors has been deprecated.

Ge0 commented 6 years ago

Oh, is this project alive eventually?

We should fix the CI then. :)

seenureddy commented 6 years ago

I have created the ticket https://github.com/klen/django_markdown/issues/82 to fix this issue.

tomasgarzon commented 6 years ago

Hi, I'm upgrading my project to Django 2.0, are you planning a new release fixing this soon?

Ge0 commented 6 years ago

I think we have to find another package...

tomasgarzon commented 6 years ago

any suggestion?

Ge0 commented 6 years ago

Not that I have heard recently.

Also, you can still fork the repo, fix the bug and release a django2_markdown pip package. That would help a lot of people for sure, me included!

tomasgarzon commented 6 years ago

Great! I'll do it!

Ge0 commented 6 years ago

Let me know here when it's done!

Ge0 commented 6 years ago

@tomasgarzon Sorry for the delay, but have you taken a look at https://pypi.python.org/pypi/django-markdown-app ?

tomasgarzon commented 6 years ago

Yes, but it doesn't have django 2.0 support, have the same problem with django.core.urlresolvers

tomasgarzon commented 6 years ago

Sorry, It has support but you should use pip install from git directly.

Ge0 commented 6 years ago

Oh I see. Maybe this project is maintained compare to django_markdown.

seenureddy commented 6 years ago

@Ge0 https://github.com/seenureddy/django_markdown fix and merge the broken Travis. Create the PR to the repo?

Ge0 commented 6 years ago

This repository is abandoned, not sure there is something to do.

abdulwahid24 commented 5 years ago

@Ge0 I see you have updated the fork with Django2.0 here https://github.com/Ge0/django-markdown-gcir. I am thinking to use it because I can't go for other packages as I am working on a legacy project which is required to migrate into Django 2.0+.

I hope there won't be any issue using https://github.com/Ge0/django-markdown-gcir. Please do let me know your thoughts.

Thanks

Ge0 commented 5 years ago

Hey @abdulwahid24

It has been a while since I last used this package. I cannot guarantee that there won’t be any issue at this time.

You’ll might have to modify the package to make it work.