klen / pylama

Code audit tool for python.
MIT License
1.05k stars 99 forks source link

Changed to use named constructor 'from_parent' #189

Closed ubaumann closed 2 years ago

ubaumann commented 4 years ago

Fix for pytest 6.0.0

https://docs.pytest.org/en/stable/deprecations.html#node-construction-changed-to-node-from-parent

ubaumann commented 4 years ago

Fix for #187 and #177

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.3%) to 77.969% when pulling 84cbc4cabd88f280eecbdaa51b692812be067417 on ubaumann:from_parent into f436ccc6b55b33381a295ded753e467953cf4379 on klen:develop.

felixonmars commented 4 years ago

There is one test failure after this patch, not sure if it's related:

=================================== FAILURES ===================================
______________________________ test_ignore_select ______________________________

    def test_ignore_select():
        options = parse_options()
        options.ignore = ['E301', 'D102']
        options.linters = ['pycodestyle', 'pydocstyle', 'pyflakes', 'mccabe']
        errors = run('dummy.py', options=options)
>       assert len(errors) == 32
E       assert 33 == 32
E        +  where 33 = len([<Error: D100 pydocstyle>, <Error: E265 pycodestyle>, <Error: E265 pycodestyle>, <Error: D101 pydocstyle>, <Error: D107 pydocstyle>, <Error: D105 pydocstyle>, ...])

tests/test_config.py:31: AssertionError
ubaumann commented 4 years ago

Checkout this pull request: https://github.com/klen/pylama/pull/188 It fixes the failing test

felixonmars commented 4 years ago

Ah great... Thanks a lot!

hkam40k commented 3 years ago

Is this going to get merged any time soon?

klen commented 2 years ago

@ubaumann Thank you for the PR. Finally the problem has been fixed.