search

klenin / Spawner

Cross-platform sandbox runner
4 stars 8 forks source link

CMake: Fix setting of WinXP compatible VS toolset. #41

Closed cher-nov closed 7 years ago

cher-nov commented 7 years ago

This fixes next issues: 1) Inability to use CMake generators that don't support toolsets (e.g. "MinGW Makefiles"). 2) Inability to use generator for VS 14 2015, because WinXP compatible toolset is "v140_xp" there.

Regression introduced by 09cd1eea1e4223afb41ea74440e5fdd438880166.

I also changed minimum required version of CMake to 3.7 because support of toolsets was introduced in 2.8.11, and GREATER_EQUAL came with 3.7.

cher-nov commented 7 years ago

@klenin,

I was wrong: actually there's no necessity to change CMake minimum required version because the one thing that depends on it is GREATER_EQUAL, which can be easily replaced by its much more supported alternative NOT LESS.

And yes, CMAKE_*_TOOLSET variables appeared in 2.8.11, but in older versions (2.6) they will be set just as plain variables, and there's no generators relying on them. CMake 2.8.11 fails to build project due to another reason, which I fixed now.

Please review.