search

kleopatra999 / webm

Automatically exported from code.google.com/p/webm
0 stars 0 forks source link

clang compiler warning in denoising_neon.c #829

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
When cross compiling chromium for ARM/linux with the latest clang in 
third_party/llvm-build/Release+Asserts/bin, I get the following warning 
(actually and error since we use -Werror):

../../third_party/libvpx/source/libvpx/vp8/encoder/arm/neon/denoising_neon.c:284
:13: error: taking the absolute value of unsigned type 'unsigned int' has no 
effect [-Werror,-Wabsolute-value]
        if (abs(sum_block - (128 * 8 * 8)) < SUM_DIFF_FROM_AVG_THRESH_UV) {
            ^
../../third_party/libvpx/source/libvpx/vp8/encoder/arm/neon/denoising_neon.c:284
:13: note: remove the call to 'abs' since unsigned values cannot be negative
        if (abs(sum_block - (128 * 8 * 8)) < SUM_DIFF_FROM_AVG_THRESH_UV) {
            ^~~
1 error generated.

Presumably the abs() should be dropped or sum_block should be made signed...

Original issue reported on code.google.com by sbc@chromium.org on 23 Jul 2014 at 12:23

GoogleCodeExporter commented 9 years ago 
Thanks for the report! This was fixed here:
https://gerrit.chromium.org/gerrit/#/c/70961/
7788c62 Fix clang compiler warning in denoising_neon.

Original comment by jz...@google.com on 8 Aug 2014 at 3:21